Adrian Li

Results 117 comments of Adrian Li
trafficstars

Yeah that's a good point. I can make a stab at doing this over the weekend, but unfortunately I don't know any Typescript. I just started a new job which...

Yeah, I can probably put out a PR this weekend. Do you have any comments on my code though? I'm pretty new to RxJS, so I'm not sure if I'm...

1. Doesn't the fact that there are two subscription statements (see the bottom of `componentDidMount()`) mean that the originating stream (i.e. `this.inputEvents$`) is being subscribed to twice? 2. Did I...

It seems to work without the `.share()` so I suppose we can take it out.

I'm actually also doubting if I'm unsubscribing properly now. I think I might need to save the subscription object from calling `.subscribe()` and then call `.unsubscribe()` on that specific subscription...

Revised example: ```jsx import React from 'react'; import { observeComponent, fromComponent } from 'observe-component/rxjs'; // Create the component with the listeners we want const TextArea = observeComponent('onInput')('textarea'); export default class...

How well does this work? I'm still on the lookout for a no-config admin solution.

Hmm should we make a push for cache busting? I'm travelling right now but if anyone wants to push that, I can approve it. Also thanks for looking into this...

Is this still happening?