adriananeci
adriananeci
> Adding yet another URL to the list of URLs that needs to be set requires strong justification IMO. Does Azure not provide a specific profile URL in the V2...
> Yikes! If a user is a member of more that 200 groups, do we really want to be storing that much data in our session anyway? Seems like we...
@JoelSpeed @braunsonm I think this PR is ready for a last round of reviews. I've tested it with both V1(https://sts.windows.net/{tenant-id}/) and V2(https://login.microsoftonline.com/{tenant-id}/v2.0) Azure Auth endpoints. The only still non working...
> @adriananeci wouldn't #1505 be solved by using the graph token that you're generating here? Not sure if you looked into the issue anymore but seems like it should be...
@braunsonm yup, all scopes were added during token acquisition: ``` result, err = app.AcquireTokenByCredential(ctx, []string{"openid", "email", "profile", azureGraphURL.String()}) ``` > Just curious if you were able to get the email...
> @adriananeci any update? I don't have any updates, I'm looking forward for any feedback from the maintainers or other interested parties. Not sure what or how to proceed further.
CI is failing most probably because `slices.Contains` statement is part of go 1.18 and CI runs using go 1.17. It is failing with: ``` GO111MODULE=on golangci-lint run Error: level=warning msg="[runner]...
I've updated CI workflow and `builder` base image from Dockerfile to go 1.18 too
@JoelSpeed @braunsonm kindly reminder
@braunsonm can we get this to the finish line and consider merging it please? We can address any issues that may pop up in followups PRs. Also, can you cut...