Aditya Sirish

+1 to more information about the problem that'd be addressed. :smile: I think communicating problems so that they can be fixed may not be worth using a VSA for. I...

@wlynch I've moved your comments about verify-mergeable over to #455 so this PR can be focused on the github app approval attestation and related functions.

Exploring if we can also track PR numbers here so we can better track dismissals but I think that can happen after this gets merged too.

This is now tracking reviewID for each approval so that dismissals can be handled. Dismissal tracking isn't perfect but I'd prefer to move ahead with something we can ship in...

@patzielinski thanks for adding tests! could you also flesh out the add approval / dismiss approval tests? @wlynch I think this is ready for your review. The predicate now has...

gotcha, can we open a ticket for this similar to #73? We can probably mock github api responses but we don't have to do it here I reckon.

@wlynch: I've opened #489 to split off the enterprise github support bits. I've also addressed a bunch of your other comments, including consolidating how we load the approval attestation predicate...

Note: I force pushed https://github.com/gittuf/gittuf/pull/439/commits/b78206675faafedab841774b2b0453e9d68c31ba because I noticed the dismiss-github-approval CLI command didn't have the `review-iD` parameter set Diff: https://github.com/gittuf/gittuf/compare/8ad004f989430ab98e68aa3dde6d3c4e1dccd892..7e1a2d77acd8fd58003339661421eb0ab757692c

https://github.com/Microsoft/Git-Credential-Manager-for-Windows/wiki/How-the-Git-Credential-Managers-works

This wasn't a credential manager issue but (more boringly) issues with buffers and newlines. Fixed in #570 and #569