Aditya Sirish

Results 379 comments of Aditya Sirish

Hi @fahdfady! There's really two things we need to consider here. A) The .git directory may be detached, so we can't even rely on that B) A single repositories may...

We should bump this way up in priority. Right now, tests are incredibly slow, in the order of ~20 mins on Windows. We should assess how many of the CreateTestRepository...

We probably want to test in powershell to unearth issues specific to that environment.

I suspect the path parsing issues are because we're using `filepath.Join`, which on windows uses `\` as the path separator, and bash is unable to handle that separator. We _don't_...

looks like it's a newline mismatch, yes?

>add-branch-rule and add-file-rule are new commands which take care of building their respective type of rules for the user. These are in addition to the existing workflow provided by add-rule,...

This looks like a major rebase is needed, let's revisit.

@wlynch left comments about verify-mergeable in #439, tracking those comments here. ~https://github.com/gittuf/gittuf/pull/439#discussion_r1649068232~ ~It's a little weird that the base branch is a flag and the feature branch is an arg....

> @wlynch: Taking a step back, there's a lot of verification logic here that feels like should be encapsulated elsewhere. Ideally I think this should look like: > > What...