Andrea Dittadi issues

Repositories
Issues
Comments

Results 1 issues of


                                            Andrea Dittadi

Potential bug in timing embedding

Hi, There might be a small bug here: https://github.com/tensorflow/tensor2tensor/blob/ef1fccebe8d2c0cf482f41f9d940e2938c816c78/tensor2tensor/layers/common_attention.py#L445-L449 I think in the last line the `exp` should be divided by `min_timescale` rather than multiplied, since it's inverse timescales. Usually...