Adam Fraser

@markspolakovs Changes look good, but it looks like the CI ee-unit-tests are failing on the new TestShardedDCPUpgrade test, waiting stale nodes to be cleaned up. Have you already looked at...

@mz2 I've taken an initial look at this, but haven't yet been able to fully assess any potential security holes that this would open up. Can you help me understand...

@mz2 Thanks for the details - I agree this is a legitimate issue, particularly around the way SG issues a SetCookie to extend session lifespan. I can see how forcing...

@mz2 If your logout API actively deletes the Sync Gateway session (i.e. issues a DELETE /_session/sessionid against the admin API), then you wouldn't have any cases of unexpected subsequent successful...

@mz2 Ah - that makes sense. On a logout/login situation, you could end up with the cookie for domain x being valid, but a stale session cookie for sg.x. This...

@snej Given that we've added REST endpoint support, can we add a feature/unsupported flag for this functionality? With that in place we'll be able to merge this.

@snej This looks good - errcheck flagged a couple of missed error checks. Let me know when those are fixed and it's rebased and we can merge.

@snej You indicate that there are no functional changes in this PR - how does that apply to the changes around unmarshalling document bodies? Can you summarize the changes being...

Perf results show a decent ~5% improvement in throughput (and accompanying reduction in CPU) - we should go ahead and review/merge based on this.

Force pushed the latest branch after rebasing on anemone, kicking off new integration tests.