Adam Li

Results 474 comments of Adam Li
trafficstars

> * [ ] Support `"precomputed"` distances Looking into this...

Resolved conflicts. Feel free to ping me if there's additional changes desired

This PR should not be affected by #28734

Apologies for the delay @adrinjalali. Assuming the CIs are green, then this should be fixed according to your previous comments.

@adrinjalali fixed the PR and removed some extra changes that became unnecessary due to the recent https://github.com/scikit-learn/scikit-learn/pull/29226

Thanks for the review @adrinjalali! I fixed up the PR to: - convert `base_estimator` to `estimator` and add a deprecation - `Bunch(fit={})` -> `Bunch(fit=params)` - update PR description to document...

> Thanks for the PR @adam2392. Here are a few comments Thanks for the review @OmarManzoor! I addressed your comments.

Thanks for the review @OmarManzoor! I'll change the last comment if @adrinjalali has any issues (https://github.com/scikit-learn/scikit-learn/pull/28494#discussion_r1650891402)

Lmk if I missed anything else @adrinjalali. Thanks for the review and patience!