Adam Li
Adam Li
> No idea where the python CI error is from. I updated your branch wrt `main`. The only remaining CI errors should be from Mac-osX Python3.9/3.10 builds, which should get...
Perhaps update your spin locally and see if https://github.com/neurodata/scikit-tree/blob/main/.spin/cmds.py needs to get modified at all? It's possible based on the obscure message seen in the CIs.
Wanna also take a stab at quick fixing the CIs related to macos images: https://github.com/actions/setup-python/issues/855#issuecomment-2096792205
We'll definitely keep the meson builds as that's the modern way of building packages with python and c++.
Rn i can't fix the meson issues but it's something you can test locally by running the same command to enable coverage to see if you can replicate. Then I...
I agree! I just meant I'd rather err on side of caution cuz the CI rn is unable to run the test suite at all. So a test could fail...
TLDR: your PR LGTM! Just want to wait on merging till we can rerun the CI.
Sure does someone want to try fixing the CI?
This is hard to support as of now because we sample oblique splits currently using a "density" hyper parameter that dictates how many non-zeros there are in the projection matrix....
@jovo any thoughts on how to best handle this?