Adam Li

Results 473 comments of Adam Li
trafficstars

Just wanted to follow up on this thread so it doesn't get lost, as I believe it's an important feature. - missing value support in extratree (the[ extratrees PR](https://github.com/scikit-learn/scikit-learn/pull/28268) shows...

Perhaps @glemaitre and @thomasjpfan can take one last look then? I think this has changed a bit since @glemaitre approved changes, and I believe I've addressed most of the core...

Good point @OmarManzoor! Added in [1441925](https://github.com/scikit-learn/scikit-learn/pull/28268/commits/1441925dce4031f43d66b9c05e6595189fbc3c93)

> I know I wish it could benefit from cython. But the orthoforest, decides its splits by fitting at every splitting decision a scikit-learn model (e.g. a Lasso). So at...

Hey @vsyrgkanis thanks for expanding. Yeah a zoom call would be great! Leaving my comments here for discussion. So IIUC, whether it is DML, or DR, we want: - first...

Sure a quick call would help! Are you on the pywhy discord? > DML is not doubly robust, just Neyman orthogonal. I see, I think I mis-read the docs because...

> Note also that grf always transforms inputs to 2d matrices. Before anything. So y here is (n, 1) and T is (n, nt). This multiplication multiplies every treatment with...

@JanMarcoRuizdeVargas to my knowledge causal discovery of clusters is a difficult and open problem. Is there a paper where one claims they can do causal discovery of clusters where the...

> > > FWIW, here are the datasets with iEEG directories with no electrodes.tsv: > > > > One of these dataset is by @adam2392 --> https://openneuro.org/datasets/ds003029/versions/1.0.6 > > >...