Adam Azarchs
Adam Azarchs
A particular(ly infuriating) edge case is this for me is when using vendored dependencies, where cargo already has, and verifies, a JSON file with cryptographic (sha256) hashes of every file...
Well, in its current state this works fine for our internal setup, which uses a hermetic python but with additional python packages installed (as required) into that python's search path,...
Never mind, the problem is a different one: it's not including the runfiles for `coverage_tool`, though it needs to.
Ok, with the addition of an integration test, I now feel like this is about ready to transition out of draft status. @TLATER would appreciate it if you have any...
Well, the integration test passes locally for me. Honestly I don't actually know what the best practice would be for making it work on the builders where it's failing. I...
I'll need to rebase this due to conflicts. I think once I'm doing that, I might actually split this PR into two, one to deal with getting pycoverage to actually...
Yes, sorry I just haven't had a chance to circle back around to this. I'll fix the conflicts and then see what I can do about the tests.
As was recommended, I updated the unit test to use a mock coverage script. After fixing various issues with other platforms, tests are now passing. I can clean up the...
Thank you for the thorough and informative review!
Test failure looks to be caused by efa196c7857945f4774a8930e6fd63c9bad698e6, unrelated to my changes. Once master is passing again I'll merge that in.