Alex Potsides

Results 520 comments of Alex Potsides

> whether to use Aegir or Unified CI The two are not mutually exclusive. [Unified CI](https://github.com/protocol/.github/blob/master/templates/.github/workflows/js-test-and-release.yml) just calls some npm scripts - `lint`, `test:node`, `test:browser`, `release` etc, if they exist...

All the `automerge.yml` and `js-test-and-release.yml` files you see in the `libp2p/js-*` and `ipfs/js-*` repos are [managed by Unified CI](https://github.com/protocol/.github/blob/master/templates/.github/workflows). To add extra repos to Unified CI, add them to the...

If you want an example of aegir used with ESM with JSDoc comments - I converted [blockstore-core](https://github.com/ipfs/js-blockstore-core) recently in [this PR](https://github.com/ipfs/js-blockstore-core/pull/45). Running this command will do most of the work...

There's some great research being done here. I'd like to express quite a strong preference for not using anything Cypress/Selenium-related in testground and instead using something based on [playwright](https://www.npmjs.com/package/playwright) (probably...

This will be fixed by https://github.com/ChainSafe/js-libp2p-gossipsub/pull/293

I have incorporated the above benchmark [into protons](https://github.com/ipfs/protons/blob/master/packages/protons-benchmark/src/rpc.ts) and running it with the latest version (5.1.0) yields good results: ```console % node packages/protons-benchmark/dist/src/rpc.js protons x 3,174,965 ops/sec ±0.40% (87 runs...

That's interesting, `[email protected]` uses the `Reader` and `Writer` classes from `[email protected]`, are you sure something else isn't affecting the benchmark run? Also, how are you generating those stats, I can't...

Please do, or if you want to create a 'bootstrap' command or standalone `create-aegir-app` tool or something that spits some default files out?

Browser tests [use playwright-test](https://github.com/ipfs/aegir/blob/master/src/test/browser.js#L42-L64) under the hood, you can use forward args to pass extra config on, eg: ```console $ aegir test -t browser -- [playwright test args here] ```...

This LGTM, but (with the exception of tempy) the version bumps are in-range semver so shouldn't be necessary. How did you come to opening this PR? Do you have a...