aegir icon indicating copy to clipboard operation
aegir copied to clipboard

fix: update typescript, esbuild, tempy

Open paralin opened this issue 3 years ago • 7 comments

Fixes an error when building where "es2021" is not in the list of known versions.

Refactor for import path changes required when upgrading to tempy 3.0.0

paralin avatar Jun 22 '22 21:06 paralin

An error is logged saying TypeScript <= 4.5.0 is supported in https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/typescript-estree but we are already using 4.6.0 here, and there's an issue discussing upgrading to 4.8.0 in the repo, and the tests appear to pass fine with 4.7.0.

See: https://github.com/typescript-eslint/typescript-eslint/issues/5227

paralin avatar Jun 22 '22 22:06 paralin

the error message is completely correct https://github.com/ipfs/eslint-config-ipfs/blob/15cbb1d71ca054ed22a8c368fafdbc251750f023/package.json#L21

you're using a ridiculously old (>10 months) version of the parser.

bradzacher avatar Jun 22 '22 22:06 bradzacher

@bradzacher Ok, trying to update it. Thanks. It's really annoying how "npm outdated" and "yarn outdated" don't flag these.

paralin avatar Jun 22 '22 22:06 paralin

it's not flagged when you run outdated here because it's a transitive dependency. if you were to run outdated in the eslint-config-ipfs folder it should show up

bradzacher avatar Jun 22 '22 22:06 bradzacher

It seems that eslint-config-standard-with-typescript is holding this up... they merged a renovate bot patch which upgrades the parser, but have not tagged a new release.

Blocked until they tag a new release unfortunately...

https://github.com/standard/eslint-config-standard-with-typescript/issues/831 https://github.com/standard/eslint-config-standard-with-typescript/issues/792 https://github.com/standard/eslint-config-standard-with-typescript/issues/840

paralin avatar Jun 22 '22 22:06 paralin

This LGTM, but (with the exception of tempy) the version bumps are in-range semver so shouldn't be necessary.

How did you come to opening this PR? Do you have a lock file in your project that needs updating?

achingbrain avatar Jun 23 '22 07:06 achingbrain

triage note: blocked on resolving eslint 8 issues first (e.g. https://github.com/ipfs/eslint-config-ipfs/pull/98)

lidel avatar Aug 12 '22 14:08 lidel

Superseded by #1164 - all deps are now up to date!

achingbrain avatar Jan 12 '23 15:01 achingbrain