Alex Potsides

Results 540 comments of Alex Potsides

:robot: Release is at https://github.com/ipfs/helia/releases/tag/strings-v4.0.4 :sunflower:

:robot: Release is at https://github.com/ipfs/helia/releases/tag/unixfs-v5.0.1 :sunflower:

:robot: Release is at https://github.com/ipfs/helia/releases/tag/utils-v1.3.0 :sunflower:

JavaScript strings are always UTF-16 (e.g. multibyte) so if you have arbitrary binary data that you stuff into a string, and a byte of that data looks like the first...

Thanks loads for opening this, it's really helpful. It's missing a test though - can you please add one to ensure there are no regressions in future. You can crib...

> This also mirrors the Kubo functionality which also requests the data from directly connected peers instead of relying solely on the DHT. It's worth noting this is Helia's default...

> The changing of the order is important here as It sends a want request immediately to its connected peers while also trying to traverse the DHT for the response....

If it helps someone, the connection failure log line: ``` libp2p:tcp:socket:error encrypting inbound connection from /ip4/X.X.X.X/tcp/58057 failed UnexpectedEOFError: unexpected end of input ``` ...normally means that the remote closed the...

Actually [server.close says](https://nodejs.org/docs/latest/api/net.html#class-netserver): > Stops the server from accepting new connections and keeps existing connections. So yes, it is necessary to close un-upgraded connections separately, but we should probably just...