Aaron Craelius

Results 312 comments of Aaron Craelius

@amaurym would be great to get your review of this too.

> > I'm fine with address.Module reverting to the pre-ADR 028 20-byte addresses (compatible with existing module accounts) when there are no derivation keys. > > > > Personally, I...

A stand-alone go module is nice but maybe premature since we don't have the new app wiring ready yet. The two main things that would be nice to see IMHO...

> Overall question, I might be missing something; what does the usage of `hashicorp/go-plugin` provide us with that simple streaming grpc implementation does not? Agree here. We already use gRPC...

> Changes look reasonable to me, but there does seem to be contention on the signature and usage of post-handlers. Namely, should we encourage safety of post-handler usage by having...

> Well since a `*Result` in passed in, a handler _could_ inspect. But why is inspection problematic? If it's used to conditionally do stuff based on Msg results that is...

> > what parts/fields of *Result do you need for your use-case(s)? > > > > @alexanderbez we need to be able to access the Result.MsgResponses in order to get...

#5694/ADR 028 is blocking, but hopefully we can resolve that soon.

At least the documentation part should