cosmos-sdk icon indicating copy to clipboard operation
cosmos-sdk copied to clipboard

Separate x/auth and vesting

Open aaronc opened this issue 4 years ago • 3 comments

Summary

As we know, x/auth is overloaded. It's primary functionality should be account authentication. But it contains much more.

Problem Definition

Recently we had a problem with x/auth migration where vesting account were vanished: https://github.com/cosmos/cosmos-sdk/issues/10591

Related:

  • [ ] #10662

Proposal

Move vesting account feature from x/auth to x/vesting and enable more feature development in a new module.

aaronc avatar Aug 17 '21 14:08 aaronc

So what are the concrete action items you had in mind @aaronc? We have a series of SDK issues that relate to vesting and I think we should create a checklist in this main issue that references them, treating this issue as an epic.

For starters, should we start by copying all vesting types to their own Go module?

alexanderbez avatar Jan 24 '22 18:01 alexanderbez

A stand-alone go module is nice but maybe premature since we don't have the new app wiring ready yet.

The two main things that would be nice to see IMHO are pulling it out of auth and allowing multiple locks per account. I.e. it should be possible to send a new bunch of vesting tokens to any existing account. The challenge is figuring out how to do this in a way that doesn't allow spam. There's been some prior design work. @amaurym do you have meeting notes from when we last looked into this?

aaronc avatar Jan 24 '22 21:01 aaronc

A stand-alone go module is nice but maybe premature since we don't have the new app wiring ready yet.

The two main things that would be nice to see IMHO are pulling it out of auth and allowing multiple locks per account. I.e. it should be possible to send a new bunch of vesting tokens to any existing account. The challenge is figuring out how to do this in a way that doesn't allow spam. There's been some prior design work. @amaurym do you have meeting notes from when we last looked into this?

Yeah, this would be awesome. Is there any plan to work on vesting to make it possible to send different vesting tokens to any existing account?

bretheren avatar Aug 28 '22 08:08 bretheren

close in favour of https://github.com/cosmos/cosmos-sdk/issues/18782

tac0turtle avatar Dec 18 '23 20:12 tac0turtle