Aaron Craelius

Results 315 comments of Aaron Craelius

> > See evmos BDD tests using ginkgo and gomega: https://github.com/evmos/evmos/blob/main/x/erc20/keeper/integration_test.go > > > > This is muchhhhhhhhh easier to understand and grok compared to this PRs approach. @alexanderbez would...

> What action does a user take to generate `build.depinject.go`? Is `go build -tags depinject` enough? They need to have some code that calls `Build`. I'm actually calling `Build` in...

Let me update this issue with some more details. I did a proof of concept implementation of this for https://github.com/regen-network/regen-ledger/tree/master/x/ecocredit. The basic way this works is: * use `apd.Decimal`'s General...

Also if a denom sets its precision to 0, it is of course simply an integer.

> @aaronc, why don't we use eric's decimal, [this pi benchmark](https://github.com/notional-labs/decimal/blob/5180d4ffc83c6ab5e9038500ffa5ae7702d9e05c/benchmarks/pi_test.go#L71) says that it has better performance than cockroachdb's decimal. Interesting. Thanks for sharing @catShaark. Let's discuss in #11783

We've never used feature branches and have no process for them. Let's just consider this epic paused

I agree this isn't pretty but I would like to see some well reasoned rationale if we're going to only allow proto.Message which will break the ORM when it is...

This is the orm's json interface for a whole module: https://github.com/cosmos/cosmos-sdk/blob/main/orm/model/ormdb/module.go It is based on this abstract json source/target interface: https://github.com/cosmos/cosmos-sdk/tree/main/orm/types/ormjson which is designed to work with the current raw...

How about this approach https://github.com/cosmos/cosmos-sdk/pull/12972/files#diff-3b60c0d2bf81b2464b20c8051fea6caef3dba18fee1cea0c437cc3d969b9a210R333 ?

I'm not at all in favor of these API "improvements" that introduce breaking changes without solving longstanding issues like streaming genesis. This in particular breaks the ORM