Aaron Craelius

Results 315 comments of Aaron Craelius

@amaurym this should probably reuse the same Coin functionality as textual. That is something we could put in core, but the need here is also for a protoreflect version which...

One pending discussion from #11877 is: > We would like to be able to customize: > * short and long usage strings for commands > * aliases for flags (ex....

I updated https://github.com/cosmos/cosmos-sdk/pull/11763 with an example using a .yaml file. The same thing could be done in a go file and it would really be the user's choice. How does...

Just a note. I don't think we need to rewrite existing tests. But new tests should likely use gotest in particular DeepEqual with protocmp.Transform when using the new protobuf API

> Gotcha. Looks like we should stick with testify's `suite` and `require` utilization, for now at least... I don't have a super strong opinion about `gotest.tools/v3/assert` vs testify `require`. They're...

I believe there should be some annotation in the .proto files to indicate which queries are deterministic and can be used inside the state machine. There may always be some...

That makes sense but can we please get rid of the global regex when we fix this

Two related issues - one the denom regex is global and mutable (seeing I had already pointed this out above). We should either make it configurable (maybe a bank keeper...

> Even if the regex is a global, the app dev can modify it which would be used by all denom verification, no? We can make it unexported if we...

Is there a way textual could handle non-ASCII denoms? What does textual do with raw strings with non-ASCII chars?