Andy Sloane
Andy Sloane
Hmm? Yes, you have to build the notes from the characters, which are all in there. Not hard.
In fact FastTracker 2 doesn't actually even use the pre-made tiny notes anywhere that I can determine. I just saw them in there and used them for convenience, and it's...
Oh, and the volume/instrument columns are printed in the "normal" font -- only the notes are "wide". Looks like this:
Ah, looks like I need to update the --enforce-gas-cost tests...
I have no idea why the legacy optimizer is changed at all...? | File name | IR-optimized (%) | Legacy-Optimized (%) | Legacy (%) | |----------------------------------------------------------------------------------------------|--------------------|------------------------|--------------| | constructor_inheritance_init_order.sol | -0.355389...
Diving into `functionCall/failed_create.sol` which is apparently 3% gassier... Apparently it's just because of all the stack shuffling attempting to preserve a 4 on the stack in slot _2. ```diff @@...
Rebased Updated diffstats | File name | IR-optimized (%) | Legacy-Optimized (%) | Legacy (%) | |----------------------------------------------------------------------------------------------|--------------------|------------------------|--------------| | constructor_inheritance_init_order.sol | -0.355389 | 0 | 0 | | constructor_inheritance_init_order_2.sol | -0.355389...
Huh, I guess this actually does break chainlink somehow, too.
> It would be nice if the rules here could be either be (1) simpler, (2) auto-generated or (3) auto-checked (as part of the CI). Agreed. I'll see what I...
Ah, I forgot about that. `createScriptProcessor()` was the replacement for the deprecated `createJavaScriptNode()`, now I gotta change it again.