Paweł Kapalla

Results 6 comments of Paweł Kapalla

I have noticed that for `GameConfig` declaration you are missing `render` property as the whole object also i am not sure if that property shouldn't be of type `RendererConfig` it...

I have noticed an issue with that solution it can obscure errors in such way you don't have any idea where it was thrown: https://github.com/TheModMaker/karma-jasmine/commit/f3fa264107cb5695ee0f906895a204c9d0efdd13#diff-e52a9a67956bd51d044af4058fb939ceR176

I have changed: ``` createOverlay: function(element, pos) { element.css('display', 'block'); var ov = new ol.Overlay({ position: pos, element: element[0], positioning: 'center-left' }); return ov; } ``` That seams to work...

Passing glob paths that glob before webpack even starts is kind of stupid and may works only on static files. I would suggest adding possibility to pass callback for running...

I see they have separate branch that fixes this problem: https://github.com/gotwarlost/istanbul/commit/4a5e92c1261bd08ce5118d01c8a05ae54fc7458b Pretty old but not merged for some reason?

I have forked it and linking fork in my projects: https://github.com/Xesenix/istanbul and in projects: ``` npm i -D github:Xesenix/istanbul ```