Xanders

Hello. If you're (or someone) still ineresting in, I've created a branch with ActiveRecord 5 fix: https://github.com/Xanders/em-synchrony/tree/active_record_5 Use it in Gemfile like: ``` ruby gem 'em-synchrony', github: 'Xanders/em-synchrony', branch: 'active_record_5',...

@dgutov Yes, it's because my fix is based on changes from that PR, so we should wait for https://github.com/igrigorik/em-synchrony/pull/190 to be merged until it will be possible to merge my...

@dgutov Is there any other way to create PR with code using code from other PR except of copy-paste all of that code? I don't understand what the problem now,...

@dgutov I've tried current master code (both active_record.rb and active_record_4.rb) with AR5 and had a lot of strange errors, didn't know how to fix them. But when i tried fork...

@dgutov So I was wrong, sorry. But I think code from that fork is much simpler and more stable, so I still prefer it. But note, I didn't write any...

@dgutov Only my app's tests. I didn't run synchrony's tests, I don't have much time. It was just a quick fix to force my app working.

@sdogruyol, I'm shoked this HUGE SECURITY BREACH still not fixed by merging this PR! Every young hacker can do any POST-requests to my application without authorization!!! I'll surely will not...

@kyrylo, thank you for reply! There is full exception for me: ``` Encoding::CompatibilityError: incompatible character encodings: UTF-8 and Windows-1251 from C:/tools/ruby27/lib/ruby/gems/2.7.0/gems/pry-0.13.1/lib/pry/code/code_file.rb:102:in `expand_path' ``` And: ``` Encoding::CompatibilityError: incompatible character encodings: IBM866...

Update according to the lastest Rails changes: https://github.com/rails/rails/blob/1a52ed178423dd727653c31398045993cd8c8cb8/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb#L212

Hi! Can you please provide some details? What are you trying to do? And also provide your Ruby version please.