Vincent Langlet

I tried a fix https://github.com/phpstan/phpstan-src/pull/4011

Hi. The question would be WHY you need to decorate admins ? You shouldn't need this, since there is already a feature named AdminExtension to add extra behavior to admins.

> It is not recommended to decorate Sonata Admin's ? Now, all extra behavour must be done in AdminExtension ? I would say this was not intended like this at...

Hi @sad270 will be fixed by https://github.com/sonata-project/SonataPageBundle/pull/1760

So `$entity->getSomethingThatIsACollection()->count()` should be prefered ? The PersistenCollection still initialize the Collection when calling `count` on it, unless the fetch mode is `FETCH_EXTRA_LAZY` which is not often used, isn't it...

Hi @greew, are you still interested in finishing in PR (and doing it on 2.1.x now) ?

> > Would it be possible to read the options ? > > Yes, implemented. Great. Could add a test for the EntityColumnRule too https://github.com/phpstan/phpstan-doctrine/blob/a1a9efb64708580a9d8b0d150340f7777d2b8aa0/tests/Rules/Doctrine/ORM/EntityColumnRuleTest.php#L35 (I assume we just need...

I tried to modify OperandsInArithmeticModuloRule in phpstan-strict-rules but I feel like I'm stuck with `numeric-string`. - `'1'` is valid - `'1.1'` should be reported - `numeric-string` may be valid but...

Hi @janedbal, float are now reported on PHP8.1+ with the PR https://github.com/phpstan/phpstan-src/pull/4406 so I think this one can be closed (?)

> Do you think we can disable the [new optimization](https://github.com/phpstan/phpstan-src/pull/2116) for huge const arrays? What could be interesting maybe is to provide configuration for constants like ``` ConstantArrayTypeBuilder::ARRAY_COUNT_LIMIT ```