Vincent Langlet

Results 667 comments of Vincent Langlet
trafficstars

Do you have time for a new review @OskarStark @nicolas-grekas ? Thanks a lot.

https://github.com/sonata-project/SonataAdminBundle/pull/8205 strategy should be preferred

Hi @mjeco-prgs @thiagomarinho This is discussion is kinda off topic the feature request I opened. I recommend you to open an issue on the fork and not in this, unrelated,...

> An alternative idea, also suggested by the comment that you've linked, was to use attributes for stamps. Can you elaborate why you dismissed that idea in favor of an...

> i tend to prefer stamps as attributes for the sake of decoupling > > having runtime flexibility is nice, but IMHO it needs to be scalable, eg. we might...

> perhaps self-stamping is the way to go for such simple runtime usecases > > no strong opinion :) > > > `#[LockStamp()] ` > > it could compute a...

Maybe you have some time for a review @nicolas-grekas ?

Friendly ping @derrabus ; would you have time for a review ?

> Except maybe that it wouldn't allow dynamism in stamp data, do you have any real life use case for such dynamism? This is a big loss for me. I...

Hi @derrabus @ro0NL @stof It's unclear to me how to move this forward. Stamp as attribute is a nice feature but should be done in another PR as it's unrealted....