Chris Ross

Results 447 comments of Chris Ross

This product is in maintenance mode, feature updates aren't expected. If someone would like to submit a PR then we can at least get this into the nightly builds.

The problem is that it doesn't know about the ClockSkew option, that's coming from an external component. At best you could skew the SystemClock abstraction by 5 minutes.

That's correct, though I can understand it's ugly. There's no expectation it will break in the future. MapForwarder won't have any special markers because it's a regular routing endpoint that...

RoundRobin operates on Destinations, and you've only supplied one. It sounds like another component is doing DNS or TCP load balancing underneath? ``` "LoadBalancingPolicy": "RoundRobin", "Destinations": { "destination1": { "Address":...

The k8s Service load balancing is TCP connection based, not HTTP request based, right? YARP will reuse connections as much as possible, so you'll only get new connections when there...

Disabling connection reuse will cause higher latency, resource usage, and potentially port exhaustion when under heavy load.

It seems like you're doing 1:1 mapping of route patterns to destinations without any of the other features like health checks, load balancing, etc. In that case the new MapForwarder...

Could this be simplified by making IISEnvironmentFeature available as a DI service instead of a feature? We wouldn't need to change IWebHostEnvironment.

It still wouldn't be available until some time after UseIIS is called, and UseIIS doesn't have direct access to IWebHostEnvironment. It would have to register for one of the Configure...