Chris Ross

Results 447 comments of Chris Ross

You're welcome to start on this. First we need a benchmark showing the cost of the current implementation with the parameters above. I don't see any docs for INodeBuilderPolicy, but...

@ksauce, can you give an example of the header values your requests normally include, and what kind of matching rules you apply?

Feature docs: https://microsoft.github.io/reverse-proxy/articles/header-routing.html Code to profile: https://github.com/microsoft/reverse-proxy/blob/33eadc66c706d3c1df8df7dafbead2873fde4fca/src/ReverseProxy/Routing/HeaderMatcherPolicy.cs#L49

@ksauce while profiling the existing design might help us gain some X% improvement, we don't think we'd make enough improvements that way to be worth the investment. There's a proposal...

Can you give some examples of the expected server configuration, request fields, and the YARP configuration you'd like to see?

Seems reasonable. There are a few ways to go about this. 1) You might be able to approximate this behavior using the Host header, it often contains the port. `"Hosts"...

https://github.com/dotnet/aspnetcore/issues/46057

The linked issue said that since the port is part of the host header you can use that: ``` { "ReverseProxy": { "Routes": { "route1" : { "ClusterId": "cluster1", "Match":...

It's easy enough to make a middleware that validates the host header matches the local port.

What does the Notify request status translate to? Aborted, failed, etc.? ``` 2021-07-21 09:12:22.9642 [Info] [0] Yarp.ReverseProxy.Forwarder.HttpForwarder+Log.Proxying : Proxying to https://172.30.50.13:5400/Notify?id=llr5GncW9Me-mzNuWzMJFQ&access_token=*** 2021-07-21 09:12:22.9993 [Info] [0] Yarp.ReverseProxy.Forwarder.HttpForwarder+Log.Proxying : Proxying to https://172.30.50.12:5400/Notify?id=llr5GncW9Me-mzNuWzMJFQ...