Results 851 comments of Tom Augspurger
trafficstars

I haven't looked closely, but it looks like the LoggingContext context manager is exiting before the logging is called. Is it being used in the right place(s)?

Seem to be some test failures. I didn't look closely, but sklearn did have a release today. Also perhaps a linting issue.

@stsievert if you merge master the unrelated CI failures should be fixed.

Still some timeout errors. The tests are running on azure pipelines, so that's what would need to be updated. That said, I worry about just xfailing these. Do you think...

IIUC, the tests are typically written with some sort of deadline for cleanup to complete. If that deadline passes without the condition then we error the test. Something like ```python...

I don't think we would want to order by class. Does scikit-learn do that? On Thu, Jun 18, 2020 at 9:58 AM austinzh wrote: > My two cents. > >...

Just to confirm: Is you question about which versions of dask-gateway are compatible with a given Dask / distributed version? This is a bit hard, since there isn't necessarily a...

Thanks for the report. I can't reproduce it locally. Can you try with the dev versions of dask and distributed? It may already be fixed.

Yes, I think so. There may be a draw_seed in utils may help. > On May 25, 2019, at 03:50, dma092 wrote: > > Is this still open? > >...

That would be a great. The docs have contributing guidelines. > On May 26, 2019, at 14:26, dma092 wrote: > > Can I work on it? > > — >...