Tim Marcus Moore

Results 106 comments of Tim Marcus Moore
trafficstars

@ignasi35 can correct me if I'm wrong, but I think the "move to core" comments were about moving them into the core Lagom framework to be used by all projects,...

@yg-apaza makes sense to me Maybe we should keep the `testkit` subpackage for the classes there. (So, `com.example.core.testkit`. Also, would it be better to call it `com.example.tools` since it's in...

@ignasi35 what would you suggest as an immediate solution to the problem of sharing code between multiple Online Auction services? Maybe it makes sense to introduce a new `testkit` subproject......

@bcabs what did it print before that?

Does the application actually work when you see this @au9ustine? Can you add your console output to the issue? Suspect that the ask timeout could be caused by under-powered machines...

See also https://github.com/lagom/online-auction-java/issues/113 and https://github.com/lagom/online-auction-java/pull/114. We should incorporate those changes as well.

Hi @Lambrina. Thanks for working on this! GitHub is only letting me assign members of the Lagom organization, but I think with the comment you've already left that should be...

P.S., this has already been implemented in online-auction-java, so it's a good idea to use the Java implementation as a guide for how it should be implemented in Scala: https://github.com/lagom/online-auction-java/blob/master/item-impl/src/main/java/com/example/auction/item/impl/ItemServiceImpl.java#L91

@nomthysmylz & @Lambrina could you let us know what your plans are for this? Would you like to collaborate on it together?