Add feature: an item owner should be able to edit an item

[ignasi35]

trafficstars

As an Item owner I want to edit an item's description and auction settings before I start the auction.

I also want to edit the description and title once the auction is already started.

[0xlbr]

Hi, can I get assigned to this task since I've already started implementing the necessary features?

[TimMoore]

Hi @Lambrina. Thanks for working on this! GitHub is only letting me assign members of the Lagom organization, but I think with the comment you've already left that should be enough to keep others from duplicating the work.

[TimMoore]

P.S., this has already been implemented in online-auction-java, so it's a good idea to use the Java implementation as a guide for how it should be implemented in Scala: https://github.com/lagom/online-auction-java/blob/master/item-impl/src/main/java/com/example/auction/item/impl/ItemServiceImpl.java#L91

[0xlbr]

@TimMoore Thank you for the advice :+1:

[ignasi35]

Hi @Lambrina and @nomthysmylz, it looks like you are both working on the same issue at once. :thinking:

[nomthy]

@Lambrina I didn't realise you were working on this too.... :grimacing: I should have rechecked this before submitting my PR :see_no_evil: :see_no_evil: :see_no_evil:

[0xlbr]

@nomthysmylz no worries, we should probably coordinate tasks better for the future though. Have you finished it yet?

[nomthy]

@Lambrina online-auction-scala/pull/27/files thats how far I had gone on this

[0xlbr]

@ignasi35 @jroper @TimMoore can I get some other feature to implement?

[ignasi35]

Hi @nomthysmylz and @Lambrina, the edit item feature is quite a big task and I think there's enough room for both to collaborate. Given clear contracts on all the services and gateway I think the task can be split.

If you ignore the verbosity of Java and some unrelated small refactors, you can get an idea of the size of the edit item task by looking at the original PR in online-auction-java: https://github.com/lagom/online-auction-java/pull/14/files Keep in mind that PR was merged before search-service existed in online-auction-java. Because search-service already exists in online-auction-scala (even though is not usable via the UI https://github.com/lagom/online-auction-scala/issues/10) an item editing will need to be properly consumed in the search service too so data in elasticsearch is consistent.

[TimMoore]

@nomthysmylz & @Lambrina could you let us know what your plans are for this? Would you like to collaborate on it together?

[0xlbr]

@TimMoore Sure! @nomthysmylz How would you like to split the work?