Adrian

Results 615 comments of Adrian

I think it'll cause more confusion than do good. Maybe warn if the other one is set instead?

Indeed - that's why I'd show a warning pointing towards the correct spelling if `SQLALCHEMY_DATABASE_URL` is set. Could even be an exception while in debug mode.

FWIW, even when using Flask-Migrate and Alembic it's usually a good idea to let SQLAlchemy deal with creating the initial revision. However, I think adding support to call `create_all` (and...

It kind of makes sense to initialize Flask-SQLAlchemy before an extension that depends on it. Doesn't seem to be a hard requirement though (at least not when using `init_app()`)

@wck821829906: Don't call `.all()` before calling `.paginate()`. Also, don't hijack unrelated issues.

There are *many* cases where COUNT and OFFSET are perfectly fine. Unless you are above ten thousands of rows in the initial resultset you can safely use them. And honestly,...

allowing non-unique model names seems like a bad idea... i'd rather have people be explicit and name one of the models e.g. `OtherUser`

Stupid question, but why change the search path instead of simply using qualified (`schema.table`) names?

Yeah, what's the state of this? This commit doesn't seem to be in `master`... > > You could always format your code with black, then re-format it with yapf. ;)...