Adrian

Results 621 comments of Adrian

Would you consider adding a short migration guide for `marshmallow_enum` users? :)

Pressing TAB inside a form field inside a modal causes the same issue. adding stopPropagation event handlers for onKeyPress, onKeyDown and onKeyUp doesn't help.

FWIW, I have multiple fields inside my modal and I'm tabbing from field 1 to field 2 in there. So no focus events leaving the modal. However, your comment gave...

How is this related to #1041? That issue seems to be about enforcing the same name a library uses to export its default with (e.g. `export default function foo() {}`)...

> Also consequently, if the default export is some nameless expression, this rule would not apply. I don't think this is helpful... as a user of a library you have...

IE11, really? Why are you using/supporting that? :) (maybe just polyfill it on your side? unless IE11 support is mentioned somewhere in the final-form docs)

> I am submitting a PR to fix this, and the contributor's guide indicates I should have an open issue to reference. This only applies to more significant changes where...

TBH the "SA 2.0" way looks more awkward for most simple usecases. I think `Model.query` should stay - without deprecation warnings. That said, a nice and dev-friendly way of supporting...

out of curiosity, why do you have multiple instances of the *same* app's context on the stack?