daemoness
daemoness
I'm similarly unfamiliar with Helix's internals, so please correct me if any of my assumptions about them are wrong. `helix_term::Config` appears to control editor-wide settings, such as the theme and...
> I think that since we're already creating a `Config` type for `Document`, it might make more sense to encapsulate the already existing configuration fields for `Document` in `Config`. That...
Alright! I can finally prioritize this again! Apologies, I know it's been a while. > I think for now just lazily loading the configs based on the Document's language should...
From the [latest run](https://github.com/helix-editor/helix/runs/6845587186): > error: package `ec4rs v1.0.0` cannot be built because it requires rustc 1.59 or newer, while the currently active rustc version is 1.57.0 Is Rust `1.57`...
EditorConfig specifies properties for inserting a newline at the end of the file if there isn't one already, as well as a trimming trailing whitespace after newlines. As far as...
What is the status of review of this PR? I really would rather not have to keep fixing merge conflicts so that it can be merged as-reviewed.
I'm still around and watching this PR if changes need to be made.
Alright. Pushed what's (hopefully) a much cleaner implementation. A few other things that have changed as a result of this: * The logic for opening `Document`s for files that don't...
Two of these questions have answers as of this PR! > How are "native" hx configs and EditorConfig settings merged? Effectively, EditorConfig settings override "native" Helix settings wherever there is...
> With #8157 recently merged, would it be a good idea to now support EditorConfig's `insert_final_newline` in this PR? I would be up for this, but I would also appreciate...