Cas_
Cas_
this is because the .ass subtitles included `YCbCr Matrix: TV.601` in their script info. does libass compensate the matrix? or does it not? if it does is there a way...
full file: [4Tsumiki.ass.txt](https://github.com/libass/JavascriptSubtitlesOctopus/files/9381981/4Tsumiki.ass.txt)
> JSO needs to know the video colourspace to accurately deal with most ASS colours. See the docs here: https://github.com/libass/libass/blob/b890df23eb8931728acdf240fd5d29e53401b4f2/libass/ass_types.h#L152-L217 > > > this is because the .ass subtitles included...
> > so then is this not the issue causing this? > > It most likely _is_ the cause. hmmmmm if TV.601 is the default value then I don't really...
@TheOneric is the only way to fix this problem is to know the video metadata, aka color space? I've been trying to read up on this, but haven't gotten much...
> > is the only way to fix this problem is to know the video metadata, aka color space? > > Yes, this is a necessary part of the solution....
seems like we could "borrow" some of the MPV code for this https://github.dev/mpv-player/mpv/blob/59fc8eecbc08d22368451b31fcf799aec557ab0d/sub/sd_ass.c
yeah, but there's a lot of other black magic happening there that I honestly can't wrap my head around and I'm not sure what a lot of it does :/
did you test if this can connect with web peers?
yeah, this seems like a potential improvement, and might be a good idea, but there's a lot of shit to be looked into, so it's likely this will go stale...