Tejesh R

Results 29 comments of Tejesh R
trafficstars

> I guess exposing no-args public constructor was wrong and it should have been protected from beginning. Also, please add a testcase. Yeah, its been used internally by other constructors...

> > > I guess exposing no-args public constructor was wrong and it should have been protected from beginning. Also, please add a testcase. > > > > > >...

> Yeah, this looks like a better idea @prrace. I will update the java doc and also will create the BufferedImage graphics from the no-arg constructor. With this we will...

@prrace, I have updated the PR, let me know if its ok now......

> Although I've reviewed the CSR I'd prefer it not be finalized yet. I think it needs more changes. The spec is SILENT about what then happens if length is...

> > > Although I've reviewed the CSR I'd prefer it not be finalized yet. I think it needs more changes. The spec is SILENT about what then happens if...

> > > > > Although I've reviewed the CSR I'd prefer it not be finalized yet. I think it needs more changes. The spec is SILENT about what then...

> OK but you need to change the title of this PR to match JBS. Sure.....