(no longer active) Gérard Talbot
(no longer active) Gérard Talbot
@SebastianZ Sebastian, I can do some review for you :) 1- The lint integration check failed. In other words, this is an important task and an important integration check to...
8- Some (several?) of your tests exceed the 600px height window viewport constraint. " The test renders within a 800x600 viewport " coming from http://web-platform-tests.org/reviewing-tests/checklist.html#visual-tests-only Eg ``` ``` in border-radius-side-shorthands-001-ref.html...
@SebastianZ At line 20 of the file box-shadow-offset-computed.html I see: `test_computed_value("box-shadow-offset", "1F0px 20px, 30px 40px");` The "**F**" should not be there.
In corner-shape-mixed-values-001.html you are testing 'corner-shape: round angle' which is 2 values while the text assert says "Three different values are supported for 'corner-shape'" - - - You have tested...
Sebastian, 10- You can safely remove the words "on the page" from the pass-fail conditions sentence everywhere. Since 95% (or so) of all tests starts with a sentence stating the...
14- Reference files should go in (move to) a /reference folder: this is best. What you did is not a mistake. But it is better to have such folder separation.
> > Same issue with border-clip-valid.html border-clip-invalid.html and maybe other tests. What you did is not necessarly a mistake but it is not ideal. > > That's the only thing...
One last modification... 15- Green and red colors should always be linked, should be hand-in-hand, should be mirrored. If you use green color in a test, then red color should...
@SebastianZ Sebastian, "there are four black squares" must become "there are four green squares" in the 2 border-radius-side-shorthands tests and in their related references. I expect to be less available...
@SebastianZ Sebastian, I have not forgotten you. I am in the middle of computer migration and personal matter that require my time and undivided attention. I will make a final...