(no longer active) Gérard Talbot
(no longer active) Gérard Talbot
> So I guess I should put all the tests in a `tentative/` folder, right? Yes. Only the tests though. Not the reference files. Not the support files.
Your parsing tests: http://www.gtalbot.org/BrowserBugsSection/CSS4BordersBoxDecorations/parsing/ Note that .js files are not at "/" but at "./" which is different from when tests are git-submitted and approved. I also appended "-SZ" to...
In parsing/box-shadow-color-computed.html at line 14, I see `test_computed_value("box-shadow-color", "currentcolor", "rgb(255, 0, 0)");` but I can not find where the spec would suggest this. In my opinion, line 14 should be...
In parsing/box-shadow-position-valid.html and in parsing/box-shadow-position-computed.html you can add `test_valid_value("box-shadow-position", "outset, inset");` and `test_computed_value("box-shadow-position", "outset, inset");`
In parsing/box-shadow-spread-computed.html at line 18 `test_computed_value("box-shadow-spread", "calc(1em + 1px)", "21px");` should be `test_computed_value("box-shadow-spread", "calc(1em + 1px)", "17px");` - - - In parsing/box-shadow-spread-valid.html at line 12 `test_valid_value("box-shadow-spread", "0", "0px");` should be...
In parsing/box-shadow-blur-valid.html at line 12 test_valid_value("box-shadow-blur", "0", "0px"); should be test_valid_value("box-shadow-blur", "0");
Sebastian, I looked at your 2c6cc45 commit and at your a762890 commit and everything seems correct and fine. I will approve your Pull request as soon as @gsnedders Sam gives...
The only small doubt I have - and that is why I thought we should have a second opinion on this - is where the /tentative/ folder should be (assuming...
I approve the commits.
Sebastian, If later there is a problem or complaint or issue with any of those 48 /parsing/ tests, then please let me know about it. Gérard