Felix Bühler
Felix Bühler
I have mixed feeling about this. I get the idea behind it, but I am seeing a bunch of unneeded ssues in this repo. With the current way we can...
on NixOS I already submitted a patch for this: https://github.com/NixOS/nixpkgs/pull/291021/commits/a00e878cb349df2837f4c746f61aeb5ddf4905ca So this is already tested by me and others.
@LasaleFamine I have no development setup locally, so I am coding blind... without testing it. Be warned. So I added some more to check for the old file and if...
@LasaleFamine so you prefer this new solution? Or do you want a combination of both?
> @Stunkymonkey thanks for the change. This feels to me the correct way to change the config file. Did you have the possibility to test it? Sadly no. I do...
could you please take over the PR? I do not have time to setup the dev-env.
why is this not implemented with [`ExtensionContext.globalState`/`ExtensionContext.globalStorageUri`](https://code.visualstudio.com/api/extension-capabilities/common-capabilities#data-storage)? Feels for me like the perfect fit.
@equinusocio we could replace https://github.com/material-theme/vsc-material-theme/blob/main/src/core/extension-manager.ts#L47 ```ts posix.join(extensionFolderUri.path, USER_CONFIG_FILE_NAME) ``` with ```ts posix.join(ExtensionContext.globalStorageUri.fsPath, USER_CONFIG_FILE_NAME) ``` But I think this would be a breaking change. see: #1295
@equinusocio I guess the PR already covers all places, where we read and write, because that is the only place `USER_CONFIG_FILE_NAME` is used.
today the same problem appeared today. i have not tested #6 yet, but @huonw please look into it.