SmallJoker

Removing limits and changing the container type does not improve anything, especially because `std::map` is O(log(n)) and `std::unordered_map` O(1) up to O(n) worse. https://en.cppreference.com/w/cpp/container :-1:

After testing with the hidroplane mod you mentioned, I can confirm that the collision time check is not well chosen. The plane is indeed more difficult to steer with the...

I have yet not tested the PR but sleeping is not too precise on non-realtime systems unless they're busy waits. Here's an explanation for the implementation on Windows: https://stackoverflow.com/a/11456112 The...

The raycast line now points to a node behind the player. In the past I have seen mods (pickpocket, anti-cheat) that would threat such interactions as invalid or malicious. The...

https://github.com/minetest/minetest/blob/0fb6dbab360813536b5b62a7ee4aa03e7757eeb4/src/mapgen/cavegen.cpp#L94 For each 5³ mapblocks (chunk), the biomes are evaluated based on the position of the first surface node (non-air) and put into a pseudo 2D array: https://github.com/minetest/minetest/blob/0fb6dbab360813536b5b62a7ee4aa03e7757eeb4/src/mapgen/mapgen.cpp#L677-L683 This could...

The code does generally look good. In another iteration, it might even be possible to make `ParticleParameters` a member of `Particle` (or by inheritance?) to avoid the unnecessary parameter copying....

A separate location makes self-updating media within mods impossible - for example skinsdb which needs access to the mod directory to update the skins. I would rather like to see...

@rubenwardy Yes, self-updating and self-initializing content in mods. > It also won't support readonly filesystems Doesn't this problem only affect shipped games, like Minetest Game and devtest? Normal mod/game installations...

What is the advantage of `View` compared to `SharedBuffer` references or `using View = std::shared_ptr;` ? It looks a bit overengineered for the functionalities that we need.

Please do not delete the entire issue template next time and use it as a guide. * How can this be reproduced? Preferably include a screenshot to visualize your problem....