Rob Janssen

What you're proposing isn't (just) order, it changes the `issuer` argument to something with a colon-separator. And that's not how it is shown in the page you linked: `otpauth://totp/ACME%20Co:[email protected]?secret=HXDMVJECJJWSRB3HWIZR4IFUGFTMXBOZ&issuer=ACME%20Co&algorithm=SHA1&digits=6&period=30` However,...

You do the honors, you've worked hard enough for it 😉

@MasterOdin While that is true, in my experience the people using (voluntarily or being stuck on) PHP 5 are not often using composer. I don't have any hard numbers and...

> And as @MasterOdin said, it's like 1% of users of this present lib. According to 1 statistic - and of which the validity is dubious in the very least....

> @RobThree Is it okay if I target 8.1 so I can use enums? If we're gonna update this lib, let's do it properly ;) Go nuts! 😉

> Only 1 hour in and already: 15 files changed, 101 insertions(+), 376 deletions(-) 🚀 Library will be even easier to maintain ;) > > I removed MCrypt stuff because...

> We're going for a major version change, so breaking API is okay Yes, but breaking as little as possible will provide the easiest path to upgrade to the latest...

It _should_ be (at least when you're using it in a read-only fashion), but the actual implementation is in [KdTree](https://github.com/codeandcats/KdTree/blob/075fb48442924cf0062371a4bfcbf03f7a93636a/KdTreeLib/KdTree.cs#L197).

I wholeheartedly agree. The *IfNotExists* in `CreateTopicIfNotExists` conveys, to me, nothing happens whenever the topic already exists. So it shouldn't emit a warning by that logic. If anything, an informational...

@dariusdamalakas Any chance you're willing to share the implementation (e.g. sourcecode)?