Rob Janssen

Results 150 comments of Rob Janssen

> Make sure google.com is really resolvable. It is. Really. > Personally, I'd put that into /etc/hosts Why? This shouldn't be necessary.... > there seems to be an issue with...

I'm not quite sure but I guess it's something to do with something that changed quite recently - be it in collectd or some shared lib or something. I haven't...

No, fixing the tests sweeps the actual problem under the rug IMHO. Yes, we can force the tests to run (for example) under `CultureInfo.InvariantCulture` but the actual "problem" is that...

> What problem is being swept under the rug Not being able to specify which culture the commandline parser should use. I may be a dutch user but depending on...

Ah, no, no it isn't. The tests just highlighted my issue. I should've chosen a better title and written a better description. My bad. I'll fix this after dinner. Sorry...

> Would using the machine settings open the door to scripts that work differently on one machine than on another? Well, that's what the current implementation with `TryParse(value, out var...

> and in fact you can use a custom format provider ...Which made me also realize we might want to be able to specify a format string (like `dd-MM-yyyy`). >...

> For reference, PHP 5.6 was end of life almost 4 years ago at this point. We've had that discussion before. I agree people should move on, but, coming from...

Yes, but `strict_types=1` is a PHP7 feature, isn't it?

> Once merged the changes will be released when Google puts out the next metadata update, in around a week if I had to guess. [8.13.1](https://repo1.maven.org/maven2/com/googlecode/libphonenumber/libphonenumber/8.13.1/) seems to be ready...