Alex

Results 67 comments of Alex

After offline discussion with @CyrusNajmabadi, we concluded on the following approach: - We dont cascade to all implied symbols deriving from the target symbol. - If we find references on...

@tmat another reminder to review this

`MSBuildWorkspacePreservesEncoding` fails at `Assert.NotNull(doc3text.Encoding);` because of the last change where we always override the encoding of the syntax tree. This behavior must also be reflected in the test, so I'll...

@tmat ptal at the changed tests and review

The symbol finder uses a mechanism to determine the documents to search for, which is also determined by the containing assembly of the symbol (if I understood correctly), which I...

It seems like the finder is flexible enough, so if I understand correctly it would be best avoided to implement the containing assembly and module symbols, if possible. However, from...

I'm referring to the `Accept` methods on the `PreprocessingSymbol` classes that take a `SymbolVisitor` to operate a visit on the symbol, which were previously throwing a `NotSupportedException`. Since the visitors...