Alex

Results 67 comments of Alex

Imo it's best to completely remove this error, for the reason I explained above. I prefer typing the extra `var _ =` to allow the inline syntax, and avoid nesting...

Oh I completely missed the point of this diagnostic, thanks for the explanation

No, but it only yields an error without causing service crashes. When this is applied to any of the analyzed attributes, multiple Roslyn service crash warnings popup, text fizzles, and...

> Was the explanation provided? I added an explanation here: https://github.com/dotnet/roslyn/pull/78514/files#diff-d901fc0a7ce2d67b0336c3708a45962ee31ae1ce7c9c67e79d3def4fc8f947bfR1913-R1916 I can reword it if you feel like it doesn't provide enough information

@AlekseyTs updated the description and brought the PR up to date, ptal

@AlekseyTs resolved your comments, could you ptal again?

@CyrusNajmabadi ptal, I'll check the failing checks soon

@CyrusNajmabadi ready for review pass Nevermind, just noticed there's a conflict. Sorry for the eager ping.

@CyrusNajmabadi this time it's actually good for review