Merlin Beutlberger
Merlin Beutlberger
Just one minor comment: [README](https://en.wikipedia.org/wiki/README) file names are *typically* written all uppercase.
Let's discuss this in the team first. I think archiving this project for the time being might be the better use of our time.
Nice. We also want to add a build step (=task) for this to the ui5-builder. Maybe we can get some reuse one way or the other.
Requires a rebase to resolve conflicts with https://github.com/SAP/ui5-linter/pull/127
I'm fine with this PR and once https://github.com/SAP/ui5-linter/pull/73#discussion_r1608011338 is clarified we can merge it. As a follow-up I would like us to extract the texts similar to https://github.com/SAP/ui5-linter/pull/112/files#diff-9d3ca30e9cd9e1355253f085c67fd2abafe4dfff649602cacf8b3ddef81db990 and hand...
GitHub requires an additional review from someone other than me 😅 @flovogt
This is caused by the following kind of `defineProperty` call: ```js Object.defineProperty(globalThis, "myProp", { configurable: "false", writable: "true", value: window.location.search }); ``` If a call like this is contained in...
I checked the newly reported findings and found them to have the same root cause as described in https://github.com/SAP/ui5-linter/issues/75#issuecomment-2061216125
https://github.com/microsoft/TypeScript/issues/55889 has been resolved. We should re-test with TypeScript 5.8 once released.
> Node.js v20.12.0 [image: image.png] Sadly that image didn't go through. Could you please try uploading it via a new comment in the browser?