ui5-linter icon indicating copy to clipboard operation
ui5-linter copied to clipboard

Published 20 hours ago • verified publisher icon SAP

feat: Detect Component best practices

Open d3xter666 opened this issue 1 year ago • 1 comments

JIRA: CPOUI5FOUNDATION-792

d3xter666 avatar Apr 16 '24 09:04 d3xter666

I don't see test cases for the other common base component classes in UI5:

sap/ui/generic/app/AppComponent sap/suite/ui/generic/template/lib/AppComponent sap/fe/core/AppComponent

These are all extending the sap/ui/core/UIComponent, so the general solution would handle them with the help of UI5 Types. Further more, if some of those classes starts implementing the async interface, that would also be matched : https://github.com/SAP/ui5-linter/blob/4c4178e8bd1ba8b3c5d290d92d11f6e3e9289273/src/linter/ui5Types/BestPractices.ts#L40

d3xter666 avatar Apr 26 '24 10:04 d3xter666

I'm fine with this PR and once https://github.com/SAP/ui5-linter/pull/73#discussion_r1608011338 is clarified we can merge it.

As a follow-up I would like us to extract the texts similar to https://github.com/SAP/ui5-linter/pull/112/files#diff-9d3ca30e9cd9e1355253f085c67fd2abafe4dfff649602cacf8b3ddef81db990 and hand them over to UA for review.

RandomByte avatar May 28 '24 13:05 RandomByte

GitHub requires an additional review from someone other than me 😅 @flovogt

RandomByte avatar May 28 '24 20:05 RandomByte