Ahmed I. Khalil

Results 13 comments of Ahmed I. Khalil

Hello It would be nice if this gets merged since I'm trying to use Hiroaki with JUnit 5 as well and I'm blocked from being not able to use `DispatcherRetainer`...

Sorry for pinging again, I apologize, but can this be merged with its current state, or there are still more work to be done?

@tasomaniac Unfortunately this is not possible for my case since I'm using Spek as my test framework, so I don't think vintage JUnit would work there (To my knowledge).

I love how this lib has become the defacto standard in reporting memory leaks that happens within Google's frameworks. Few weeks ago I reported a memory leak in the navigation...

Also when running tests from gradle I notice that Spek and JUnit5 are both running, even-though I specified the `--tests` to run just the JUnit one. ``` $ ./gradlew testDebug...

Unfortunately I'm still suffering from this problem, one workaround that I discovered is executing single test methods doesn't trigger this bug, unlike when trying to run the entire class. It's...

`SupportSQLiteDatabase` is going to get this method soon for other non-framework bindings like Requery to implement. https://android-review.googlesource.com/c/platform/frameworks/support/+/1491164/

Facing the same problem as well with Hilt's FragmentContextWrapper, however I'm not sure if that's Epoxy's fault or Hilt's. Maybe If Hilt somehow can provide a way to disable the...

Clearing the adapter in `onDestroyView` seems to fix the problem without the need to use the Activity's LayoutInflater. ``` override fun onDestroyView() { requireView().findViewById(R.id.epoxy_view).adapter = null super.onDestroyView() } ```

Hi, Thanks for volunteering! If you have time then why not ;) Do you know the required dimensions for the icons? If not you can start with [1] [1] https://developer.android.com/google-play/resources/icon-design-specifications