Qun Cheng

Results 63 comments of Qun Cheng
trafficstars

> Looks like this PR is significantly behind `main`. You need to bring this up to date, as the latest PR contains a fix for the CI breakage. Just rebased...

> > > Looks like this PR is significantly behind `main`. You need to bring this up to date, as the latest PR contains a fix for the CI breakage....

> > In this case, should I wait until the recent code merge into stable channel? > > Just to confirm, we can update the CI config to ignore this...

> @QuncCccccc should this PR be closed? Yes, thanks for reminding me!

> Some code style issues will be more obvious once the CI pipeline is integrated. It'll pick up things like single vs double quoted strings. Should I give a larger...

> Please add this project to [`flutter_ci_script_master.sh`](https://github.com/flutter/samples/blob/main/tool/flutter_ci_script_master.sh) to kick in the master CI pipeline. Just added. Please let me know if there's any problems.

> Is there an update on this? A timeplan? Hi! I'm working on it and will create a pr once it's ready. Thanks for asking!

> @guidezpl > > 1. Will Flutter exactly repeat this behavior of the switch? > ![unnamed (1)](https://user-images.githubusercontent.com/102767277/191384842-bb77750f-239a-4bc7-8274-6ffc2f312bd0.png) > 2. If we talk about this switch in Flutter, then when it...

> Is there a separate pull request for the additional changes? Yes, I will raise a pr for these changes soon.

While we are fixing this issue, could you also try if [`DropdownMenu`](https://api.flutter.dev/flutter/material/DropdownMenu-class.html) can satisfy all your requirements? It is a new widget in Material3 with a Material3 style and the...