Yunsong Wang
Yunsong Wang
> INT96 has been long deprecated, so I don't see much use in trying to get statistics to work with them. In fact, the parquet thrift file specifically [says](https://github.com/apache/parquet-format/blob/e91ab5e892391bd179d3c16b7c1cf4fbaeebbfe7/src/main/thrift/parquet.thrift#L972) the...
Yeah, using `std::optional` to properly handle optional field reading/writing was on my TODO list but then got distracted by other tasks.
_**Question to reviewers**: is it worth doing runtime dispatching based on whether nested types are involved or not?_ Benchmark results are shown below, TLDR: - The hash table size is...
@vyasr Thanks for the review, have you reviewed both cpp and python or do I need another cpp/python approval to merge the PR?
@vyasr @shwina I've updated the doc as suggested and marked this work as a breaking change. Thanks for your comments.
Notes: Users cannot specify the function name with `CUDF_FUNC_RANGE`:  Custom ranges can be done via `cudf::thread_range`, i.e. `hash_join::inner_join`: 
/merge
> These type check functions are now employed throughout the code base instead of raw checks like a.type() == b.type() Maybe out of the scope of the current PR but...
We need to also make sure the dependent headers of `data_structure.cuh/hpp` (the example shown below) can work with non-CUDA compilers, i.e. separating declarations with implementations and guarding all implementations with...