cudf
cudf copied to clipboard
Clean up nvtx macros
Description
This PR includes several cleanups for the cudf nvtx wrappers:
- Removed the unused
NVTX3_FUNC_RANGEmacro - Fixed a typo in the doc
- Added an example in the
cudf::thread_rangedoc - Updated the
NVTXsection in the developer guide doc
Checklist
- [x] I am familiar with the Contributing Guidelines.
- [ ] New or existing tests cover these changes.
- [x] The documentation is up to date with these changes.
Notes:
Users cannot specify the function name with CUDF_FUNC_RANGE:
Custom ranges can be done via
cudf::thread_range, i.e. hash_join::inner_join:
You could always just call nvtxRangePushA(custom-name)' and 'nvtxRangePop()
Also, this reminds me that the vendored version of nvtx in cudf is wildly out of date and should be removed. See https://github.com/rapidsai/cudf/issues/6476
/merge