MrOctopus

Results 9 comments of MrOctopus

The fix is simple: Don't add add an old promise-batcher version to your direct dependencies. Do an override of the peer dependency itself: `"overrides": { "promise-pool-executor": { "promise-batcher": "1.0.2" }...

I am aware that the C++ inline specifier is just a suggestion to the compiler to enforce inlining (though it most most often follows this suggestion). As for the distinction...

That's understandable, but I would argue that inlining is more important for Papyrus to stay performant because of the function call overheads; which do add up, believe me on that....

I agree with you that a big fat warning in the docs will probably be enough. If I have any other suggestions/resources I'll be sure to provide them.

I should also note that the SkyUI source you are using is out-of-date. The up-to-date one can only be garnered by decompiling the SkyUI SSE compiled scripts and fixing up...

Good observation! Though it seems like that's also the actual correct Slot Mask according to [this ](https://www.creationkit.com/index.php?title=Slot_Masks_-_Armor) article. Of course, the while loop still remains bugged. I am unsure if...

```go filters := client.Player(guildID).Filters() log.Debug().Msgf("Value is currently: %+v AND %+v", filters.Karaoke, filters.Vibrato) switch filter { case FilterTypeKaraoke: filters.Karaoke = &lavalink.Karaoke{ Level: 1.0, MonoLevel: 1.0, FilterBand: 220.0, FilterWidth: 100.0, } case...

```go var increment int func (b *Bot) FilterCommandTest(data discord.SlashCommandInteractionData, e *handler.CommandEvent) error { player := b.Lavalink.ExistingPlayer(*e.GuildID()) if player == nil { return e.CreateMessage(discord.MessageCreate{ Content: "No player found", }) } filters...