Adrian Edwards

Results 226 comments of Adrian Edwards

> Say ClassClock detects that the school was set up in PST and the user is in a different timezone (EST). The selection would offer the user two options: ......

you mean like this? https://stackoverflow.com/questions/46056414/getting-404-for-links-with-create-react-app-deployed-to-github-pages#46060999 or https://create-react-app.dev/docs/deployment/#serving-apps-with-client-side-routing > When you enter a new URL into address bar of the browser or refreshes the page, browser requests server (in this case...

switching from universal-router to https://github.com/mksarge/redux-json-router#usage may also fix this and provide additional benefits like allowing for a wildcard route path that can lead to a custom classclock-style 404 page on...

This is fixed in the dev branch and will be part of the next release

Thanks for the suggestion! To be honest I think the icon originally created just so that there was _something_ to use as a logo and/or home screen icon. That said,...

ohhh that makes more sense, I thought you meant like displaying the icon to the user inside the `` of the page. There are already 512px and 192 px icons...

well that definitely isn't supposed to happen. Thanks for the sample code! I'm not sure when I will be able to get around to making this change though, so if...

upon some further investigation, it seems like thee icons may have been configured correctly, but the [redux-first-routing](https://github.com/mksarge/redux-first-routing/blob/master/docs/recipes/usage-with-universal-router.md) model of the app is not configured to correctly returning the appropriate assets....

also probably caused by the same or similar routing issues that are causing #25

this could also be caused by whatever software is bundling the app up seemingly not including the image assets from the `/icons` directory