Roland Fredenhagen

Results 292 comments of Roland Fredenhagen

I looked into how the API could look for using completions with derive/builder pattern. The current approach in the dynamic example, to apply manually with augment_subcommands feels a bit laborious,...

> > I looked into how the API could look for using completions with derive/builder pattern. > > This seems separate from the discussion of fish, right? Can we break...

So AFAICT fish would only need a function it can call with the current line+cursor position and get all the available completions where: 1. Options are only returned if current...

This implements dynamic completions for fish now, and I put some shell agnostic completion logic in the dynamic module, that should deal with all the intricacies of parsing arguments correctly...

One thing that I'm not certain about is, if my handling of OsStrings due to utf8 incompatible strings is ideal or needs to be reworked.

I tried documenting it in the description. And you're right, I mixed these commit up a bit and will clean them up in the next days.

Cleaned up my commits a little bit.

> I would recommend we work together to figure this out. That sounds like a good idea, what method would you prefer? Written discussion here or a voice call? >...

Moved derive api support to #4356

I started writing the fish requirements into the hackmd, on deciding what fish would need additionally, I was unsure about what the current completion implementation actually provides and what all...