Micha Reiser

Results 702 comments of Micha Reiser
trafficstars

> I have some concerns about a numerical metric. Testing out Rome on some small projects, I've noticed that there are large diffs that occur from very small changes like...

@leops how did you add the Prettier tests? Do you have that script still somewhere with some instructions on how to run it?

See #2579 for the work around getting Rome closer to Prettier.

@ematipico are you looking for a more extensive documentation than what's exposed in the [API documentation](https://rome.github.io/tools/rome_formatter/prelude/index.html)

Prettier's formatting as reference: ```js deepCopyAndAsyncMapLeavesC( { source: sourceValue, destination: destination[sourceKey] }, 1337, { valueMapper, overwriteExistingKeys } ); ``` So it might be that we're just picking the "incorrect" layout.

I think the issue here is another one. I haven't looked very deeply but the call arguments formatter emits two different IRs for the first and second formatting. First: ```...

> This normalization is actually [number-to-string](https://tc39.es/ecma262/#sec-numeric-types-number-tostring) from the spec. > > I think we can use https://crates.io/crates/ryu-js, it's from https://github.com/boa-dev/boa > > > Ryū-js is a fork of the [ryu](https://crates.io/crates/ryu)...

> Do you think we could achieve that with only string manipulation? We can't use regex unfortunately (it's better not to) Sure. A RegEx is just a state machine. The...

Duplicate of #3294

Ok, I was wrong. I tested the auto functionality in more detail and found out, that it is more related to a timing issue. What I see is that the...